Page 3 of 5

Re: Boldly going where no hawkdawg.com has gone before

Posted: Sat Oct 12, 2019 8:30 pm
by Gumboots
Exactly. I'm thinking nobody in the right mind will want any of the others, so I might save myself some work and knock them on the head so I don't have to consider them when writing custom code.

The button menu extension is good for basic functionality, but can easily be made more flexible and more compatible with the range of styles here. All it needs is ripping out the hard-coded variables for colour, maybe throw in a class or two for easier targetting, and then do the colours via CSS additions to an existing file. That way it's easy to adjust it to fit any presentation.

Can make it more responsive while I'm at it. The same basic code can be pasted everywhere and just given slight tweaks to suit. But I don't want to have to make it fit gruesome variants that nobody will use, so hiding those seems like a clever idea. ;-)

Re: Boldly going where no hawkdawg.com has gone before

Posted: Sat Oct 12, 2019 9:21 pm
by Hawk
Just remember that whatever changes you make to the default code stuff will be overwritten when/if you update the software again.
I don't remember exactly how to do it, but there's a way you can make your own edits by making a copy of styles in the ACP and doing it there, or something like that.

That's why the header didn't carry over to the new forum software/styles; because I made changes to the code itself.

Re: Boldly going where no hawkdawg.com has gone before

Posted: Sat Oct 12, 2019 9:38 pm
by Gumboots
Yup. Not a problem. I can do all sorts of tricks if I really have to. Main thing is to keep a backup of any edited files, along with enough notes so I know what I'm looking at when I dig it up after six months or whatever.

Actually, come to think of it, how on earth do you comment phpBB files if they're using that weird syntax? There must be a way to do it (but I bet if I ask they'll say "Don't edit core files" and "You need an extension to do that".)

Re: Boldly going where no hawkdawg.com has gone before

Posted: Sat Oct 12, 2019 9:48 pm
by Hawk
Which files are you asking about?

Of course, for html it's like this:

Code: Select all

<!-- comment -->
And for the css, it's

Code: Select all

/*  comment  */
But then, you already know that.

Then there's the js file, which is:

Code: Select all

// comment
and for cfg it's

Code: Select all

# comment
I think that about covers all the file types used in phpbb.

BTW! Here's a link about editing styles. - https://www.phpbb.com/styles/installing/

Re: Boldly going where no hawkdawg.com has gone before

Posted: Sat Oct 12, 2019 9:53 pm
by Gumboots
I mean the HTML files. They're using HTML comment syntax to include their PHP conditionals, so I was wondering how they do actual comments. But I've been taking a look and it appears they still use HTML comment syntax. For example:

Code: Select all

<!-- IF U_CANONICAL -->
	<link rel="canonical" href="{U_CANONICAL}">
<!-- ENDIF -->

<!--
	phpBB style name: we_universal
	Based on style:   prosilver (this is the default phpBB3 style)
	Original author:  Tom Beddard ( http://www.subBlue.com/ )
	Modified by:      nextgen ( http://xeronix.org/ )
	Modified by:      v12mike ( v12mike@ingenious.co.nz )
-->
The first is a PHP inclusion, and the second is (as far as I can tell) an actual comment. So it may just depend on if phpBB recognises an actual IF or variable after the comment opening tag. Or, it may depend on actual comments breaking to a new line after the opening tag. Not sure at the moment, but will find out.

PS: Preview is working for me, on Aero Black.

Re: Boldly going where no hawkdawg.com has gone before

Posted: Sat Oct 12, 2019 9:56 pm
by Hawk
I see what you mean. Weird! I guess the way they write html and php, the html reads the php syntax in an html comment tag.
I don't know. **!!!** !hairpull! :lol:
Gumboots wrote: Sat Oct 12, 2019 9:53 pm PS: Preview is working for me, on Aero Black.
Yea, it's working fine for me now. It didn't work for a couple minutes, but then started working again.

Re: Boldly going where no hawkdawg.com has gone before

Posted: Sat Oct 12, 2019 9:57 pm
by Gumboots
Maybe it wants a rest on Sunday.

Edit: Just noticed I'm getting white pages on PM's too. It may be because I'm taking a backup of the attachments directory and have temporarily bumped disc usage over the limit. Limit is 5.86 gig, and with the backup tarball there it's been bumped to 6 gig.

Will have it downloaded and deleted in about 20 minutes, so will check all functionality then.

Re: Boldly going where no hawkdawg.com has gone before

Posted: Sat Oct 12, 2019 10:01 pm
by Hawk
Maybe things will settle down after all is said and done. Something to keep an eye on though.

BTW! I did edit my previous post while you were posting, so you may have missed what I added.

Re: Boldly going where no hawkdawg.com has gone before

Posted: Sat Oct 12, 2019 10:04 pm
by Hawk
I just checked and I'm getting white pages on PM's too.

Re: Boldly going where no hawkdawg.com has gone before

Posted: Sat Oct 12, 2019 10:08 pm
by Hawk
I'm getting a white page on MCP too.